Skip to content

Conversation

@twz123
Copy link
Contributor

@twz123 twz123 commented Dec 22, 2025

When a connection attempt is canceled after the transport is created, ensure that it is closed inline. This prevents untracked goroutines from being left behind.

See:

RELEASE NOTES:

  • When canceling a connection attempt, closing the transport won't use an untracked goroutine anymore.

When a connection attempt is canceled after the transport is created,
ensure that it is closed inline. This prevents untracked goroutines from
being left behind.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.29%. Comparing base (4046676) to head (5ccc206).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8786      +/-   ##
==========================================
- Coverage   83.42%   83.29%   -0.13%     
==========================================
  Files         418      418              
  Lines       32897    32898       +1     
==========================================
- Hits        27443    27402      -41     
- Misses       4069     4093      +24     
- Partials     1385     1403      +18     
Files with missing lines Coverage Δ
clientconn.go 90.81% <100.00%> (+0.12%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@twz123 twz123 marked this pull request as ready for review December 22, 2025 13:16
@mbissa mbissa assigned mbissa and eshitachandwani and unassigned mbissa Dec 24, 2025
@eshitachandwani eshitachandwani self-requested a review January 2, 2026 06:26
@eshitachandwani eshitachandwani added this to the 1.79 Release milestone Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants