xds: Add IsDynamic field to cdsbalancer LB and make it true for RLS
#8793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshitachandwani
added
Type: Internal Cleanup
eshitachandwani
changed the title
Is_Dynamic field to cdsbalancer LB and make it true for RLS configIs_Dynamic field to cdsbalancer LB and make it true for RLS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8793 +/- ##
==========================================
- Coverage 83.42% 83.35% -0.07%
==========================================
Files 418 418
Lines 32897 33004 +107
==========================================
+ Hits 27443 27510 +67
- Misses 4069 4092 +23
- Partials 1385 1402 +17
🚀 New features to boost your workflow:
|
easwars
reviewed
Jan 6, 2026
| type lbConfig struct { | ||
| serviceconfig.LoadBalancingConfig | ||
| ClusterName string `json:"Cluster"` | ||
| IsDynamic bool `json:"Is_Dynamic"` |
Contributor
There was a problem hiding this comment.
We use camelCase (starting with a lower case) for the json annotations. See the outlier detection LB policy's config definition for an example:
Member
Author
There was a problem hiding this comment.
Got it! Changed both. Since the Cluster field was capital , I got confused.
Contributor
There was a problem hiding this comment.
Since the Cluster field was capital
Hmm ... that is weird.
Looks like the json package uses the tags in a case insensitive manner. See: https://pkg.go.dev/encoding/json
easwars
approved these changes
Jan 6, 2026
Contributor
|
The PR title needs to be updated to not include the underscore. |
eshitachandwani
changed the title
Is_Dynamic field to cdsbalancer LB and make it true for RLSIsDynamic field to cdsbalancer LB and make it true for RLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Part of A74 changes.
This PR add a new
IsDynamicfield to the CDS balancer LB Config. Also sets it to true for RLS cluster specifier plugin.This PR also fixes the test in rls_test.go which earlier was returning if the test has
wantError=trueeffectively not testing the cases after that.This will be used to dynamically start watch for cluster specifier plugin clusters from cds balancer.
RELEASE NOTES: None