xds: test changes #8794
xds: test changes #8794
Conversation
eshitachandwani
added
Type: Internal Cleanup
eshitachandwani
force-pushed
the
minor_test_change
branch
from
2838498 to
d83dd4b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8794 +/- ##
==========================================
- Coverage 83.42% 83.36% -0.06%
==========================================
Files 418 417 -1
Lines 32897 32978 +81
==========================================
+ Hits 27443 27491 +48
- Misses 4069 4084 +15
- Partials 1385 1403 +18 🚀 New features to boost your workflow:
|
|
Please add a more descriptive title and description. This is what we recommend for our external contributors: https://github.com/grpc/grpc-go/blob/master/CONTRIBUTING.md#pr-descriptions |
|
|
||
| // Replace DNS resolver with a wrapped resolver to capture ResolveNow calls. | ||
| resolveNowCh := make(chan struct{}, 1) | ||
| resolveNowCh := make(chan struct{}, 3) |
There was a problem hiding this comment.
Why do we need this change? How is a reviewer supposed to understand the motivation for this change?
There was a problem hiding this comment.
This was a flaky test which I thought was because of my changes but this is an already flaky test which pranjali is working on fixing , so reverting the change now.
There was a problem hiding this comment.
Flake reported in this issue is caused by the changes made for logical-dns.
Fixed this in adb4625.
|
|
||
| const ( | ||
| defaultTestTimeout = 10 * time.Second | ||
| defaultTestTimeout = 20 * time.Second |
There was a problem hiding this comment.
Same here. Why do these tests need 20s to run?
There was a problem hiding this comment.
Earlier, with my changes , the test was taking around 15 secs to pass, because the EDS update was taking a tittle longer to be received.
But that doesn't seem to be the case anymore after a few other changes, so reverting the change.
4 participants
This PR fixes the
TestErrorFromParentLB_ResourceNotFoundto reconfigure the same CDS and EDS resources after they have been removed instead of configuring all the new resources.Also removes unused
defaultTestShortTimeoutfrom internal/xds/balancer/clustermanager/clustermanager_test.goRELEASE NOTES: None