-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientCalls.ThreadlessExecutor should reject Runnables after end of RPC #3557
Comments
Note: this is made more complicated by grpc's current handling of application exceptions (centering around |
Reverted by #7920. It found a bug! |
As seen in #3537, the executor was being used for multiple RPCs which caused some Runnables to be queued but never run. We are in a position to know they will never execute though, so it'd be nice to have a (possibly unreliable) detection of rejected Runnables to notice issues like this earlier.
This could be accomplished with just a volatile
shutdown
boolean that is checked beforeexecute()
and ashutdown()
method. That's racy, but we're just wanting it to detect bugs, not provide correctness.The text was updated successfully, but these errors were encountered: