Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most of the functions in AbstractStub should be annotated with @CheckReturnValue #3985

Closed
Hzj-jie opened this issue Jan 19, 2018 · 1 comment
Milestone

Comments

@Hzj-jie
Copy link

Hzj-jie commented Jan 19, 2018

These functions create new instances rather than changing the internal state, e.g.
stub.withCallCredentials( ... )
is wrong. One should always use
stub = stub.withCallCredentials( ... )

public abstract class AbstractStub<S extends AbstractStub<S>> {

@carl-mastrangelo
Copy link
Contributor

Static analyzers will fail if the value is not checked, which is likely extremely high at this point. While the code is probably buggy, I don't think it can reasonably be fixed at this point.

@carl-mastrangelo carl-mastrangelo added this to the Unscheduled milestone Jan 19, 2018
@ejona86 ejona86 modified the milestones: Unscheduled, 1.13 May 15, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants