Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub: Add @CheckReturnValue to AbstractStub #4437

Merged
merged 1 commit into from
May 4, 2018

Conversation

groakley
Copy link
Contributor

@groakley groakley commented May 4, 2018

No internal google targets were broken by this change.

Fixes #3985

@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 4, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 4, 2018
Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groakley
Copy link
Contributor Author

groakley commented May 4, 2018

Linking this relevant comment about errorprone versions from a similar change here. #4427 (comment)

@carl-mastrangelo carl-mastrangelo merged commit dbf9bd2 into grpc:master May 4, 2018
@carl-mastrangelo
Copy link
Contributor

@groakley I will try bringing this in, but in case it fails to import we may have to roll back.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants