Log warning message when server side gets exception writing message to stream and allow multiple closes #10513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o stream. Change the case where close is called twice from an error to a noop. Fix aarch_64 macs not being able to build the compiler module.
ejona86
reviewed
Aug 23, 2023
…ption. Change argument to internalClose to a Throwable instead of a Status.
ejona86
approved these changes
Aug 24, 2023
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 24, 2023
…o stream and allow multiple closes (grpc#10513) * Use internalClose instead of close when sendMessage has a RuntimeException. * Change argument to internalClose to a Throwable instead of a Status. * Rename internalClose to handleInternalError
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 29, 2023
…o stream and allow multiple closes (grpc#10513) * Use internalClose instead of close when sendMessage has a RuntimeException. * Change argument to internalClose to a Throwable instead of a Status. * Rename internalClose to handleInternalError
larry-safran
added a commit
that referenced
this pull request
Aug 29, 2023
) (#10520) * Log warning message when server side gets exception writing message to stream and allow multiple closes (#10513) * Use internalClose instead of close when sendMessage has a RuntimeException. * Change argument to internalClose to a Throwable instead of a Status. * Rename internalClose to handleInternalError * Update ServerCallImplTest.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When server side sendMessage throws a RuntimeException, call
handleInternalError()(previously internalClose) rather than close. This will log a warning.rename internalClose to handleInternalError and change argument from a Status to a Throwable.
Allows more debugging of #10500