Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GAE interop tests to use java11 runtime #10933

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Feb 20, 2024

The Java 8 runtime is end of support. Leaving this a gae-jdk8 for now. The gae-jdk8 was because AppEngine changed dramatically from Java 7 to Java 8. Nowadays the versions are more in line with OpenJDK and not very different from each other.

Fixes #10925

The Java 8 runtime is end of support. Leaving this a gae-jdk8 for now.
The gae-jdk8 was because AppEngine changed dramatically from Java 7 to
Java 8. Nowadays the versions are more in line with OpenJDK and not very
different from each other.

Fixes grpc#10925
@ejona86 ejona86 marked this pull request as ready for review February 20, 2024 16:37
@ejona86
Copy link
Member Author

ejona86 commented Feb 20, 2024

My main goal is to get this working again. We'll want to come back to it and upgrade it further, as Java 11 support doesn't last long: https://cloud.google.com/appengine/docs/standard/lifecycle/support-schedule#java

@ejona86 ejona86 requested a review from larry-safran February 20, 2024 16:44
@ejona86 ejona86 merged commit 071a784 into grpc:master Feb 20, 2024
13 of 14 checks passed
@ejona86 ejona86 deleted the gae11 branch February 20, 2024 18:52
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Feb 24, 2024
The Java 8 runtime is end of support. Leaving this a gae-jdk8 for now.
The gae-jdk8 was because AppEngine changed dramatically from Java 7 to
Java 8. Nowadays the versions are more in line with OpenJDK and not very
different from each other.

Fixes grpc#10925
ejona86 added a commit that referenced this pull request Feb 24, 2024
The Java 8 runtime is end of support. Leaving this a gae-jdk8 for now.
The gae-jdk8 was because AppEngine changed dramatically from Java 7 to
Java 8. Nowadays the versions are more in line with OpenJDK and not very
different from each other.

Fixes #10925
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAE CI is broken. Java8 is dead-ish
2 participants