s2a: Address minor comments on PR#11113 #11540
Conversation
rmehta19
force-pushed
the
s2a-small-fixes
branch
from
1e8485c
to
577b4e5
Compare
rmehta19
force-pushed
the
s2a-small-fixes
branch
from
bbfe93b
to
e637a73
Compare
rmehta19
force-pushed
the
s2a-small-fixes
branch
from
e637a73
to
df413b1
Compare
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
Hi @ejona86 & @larry-safran, are there any additional comments for me to address on this PR? |
|
|
||
| // src/test/resources/leaf_key_ec.pem |
There was a problem hiding this comment.
What's special about this one that it isn't being read from the file?
There was a problem hiding this comment.
This is the same key as in leaf_key_ec.pem, it just has newlines removed.
There was a problem hiding this comment.
I don't understand how that answers my question. It is a literal string to avoid removing the newlines? string.replaceAll("\n", "")
Looks like it also has the header/footer removed. Is io.grpc.util.CertificateUtils.getPrivateKey() what you need?
There was a problem hiding this comment.
Yes, done in 48e8c7f
| prompt = no | ||
|
|
||
| [req_distinguished_name] | ||
| O = o |
There was a problem hiding this comment.
Every level has the same subject name? That just seems like we hate our future selves if we ever have to debug. Let's make them unique in some way.
* Use StandardCharsets in FakeS2AServerTest. * Use add instead of offer in S2AStub. * remove dead code in ProtoUtil.java. * Mark convertTlsProtocolVersion as VisibleForTesting. * S2AStub doesn't return responses at front of queue. * Remove global SHARED_RESOURCE_CHANNELS. * Don't suppress RethrowReflectiveOperationExceptionAsLinkageError. * Update javadoc. * Make clear which certs are used in tests + add how to regenerate.
Address minor comments on #11113