netty: Removed 4096 min buffer size #11856
Conversation
There was a problem hiding this comment.
We need to include more context. At the very least this (the commit and the PR description) should have a "Fixes #11719" to associate it with the issue (and it will also auto-close the issue when merging). But we should also summarize why we are making the change. I'd say something like, "MessageFramer.flush() is being called between every message, so messages are never combined and the larger allocation just wastes memory."
netty/src/test/java/io/grpc/netty/NettyWritableBufferAllocatorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
You'll want to "squash and merge" using the github button. It will give you the opportunity to write the commit message, and you'll want to clean it up, because it gives a very poor default (it is a useful default, as it gives you all the words you may want to adjust, but it will need editing).
Yeah, looks like you'll want to copy from your PR description to fill in the commit description. |
|
I see you created the branch in the grpc/grpc-java repo. You should generally have the branch in your own fork/repo instead. |
|
Looks like you didn't clean up the commit message (nothing to be done about it this time, but can try to avoid the mistake in the future): |
* netty: Removed 4096 min buffer size
* core: updates the backoff range being used from [0, 1] to [0.8, 1.2] as per the A6 redefinition * adds a flag for experimental jitter * xds: Allow FaultFilter's interceptor to be reused This is the only usage of PickSubchannelArgs when creating a filter's ClientInterceptor, and a follow-up commit will remove the argument and actually reuse the interceptors. Other filter's interceptors can already be reused. There doesn't seem to be any significant loss of legibility by making FaultFilter a more ordinary interceptor, but the change does cause the ForwardingClientCall to be present when faultDelay is configured, independent of whether the fault delay ends up being triggered. Reusing interceptors will move more state management out of the RPC path which will be more relevant with RLQS. * netty: Removed 4096 min buffer size (#11856) * netty: Removed 4096 min buffer size * turns the flag in a var for better efficiency --------- Co-authored-by: Eric Anderson <ejona@google.com>
Fixes #11719
MessageFramer.flush() is being called between every message, so messages are never combined and the larger allocation just wastes memory. The change removes the restriction on the min buffer size and hence, prevents the said wastage.