Skip to content

[xDS] A97 - JWT token file call creds #12242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[xDS] A97 - JWT token file call creds #12242

wants to merge 15 commits into from

Conversation

Zgoda91
Copy link

@Zgoda91 Zgoda91 commented Jul 23, 2025

implementing gRFC A97 grpc/proposal#492

@Zgoda91 Zgoda91 force-pushed the A97_jwt_token_call_creds branch 4 times, most recently from a8f76b0 to c781460 Compare July 28, 2025 06:26
@Zgoda91 Zgoda91 marked this pull request as ready for review July 28, 2025 06:27
@Zgoda91
Copy link
Author

Zgoda91 commented Jul 28, 2025

@ejona86 Could you please review this PR when you get a chance? Thanks!

@ejona86 ejona86 self-requested a review August 6, 2025 21:11
ejona86
ejona86 reviewed Aug 6, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shape of what I saw looked good. I didn't pay attention to any of the tests yet. I need to look through the provider plumbing more. But wanted to send the comments I have.

@Zgoda91 Zgoda91 force-pushed the A97_jwt_token_call_creds branch 2 times, most recently from 85495b0 to 9f97bb5 Compare August 11, 2025 12:36
@Zgoda91
Copy link
Author

Zgoda91 commented Aug 11, 2025

@ejona86 PR ready for second round

@ejona86 ejona86 self-requested a review August 20, 2025 20:01
@Zgoda91
Copy link
Author

Zgoda91 commented Sep 11, 2025

@ejona86 kindly reminder about this forgotten piece :)

ejona86
ejona86 reviewed Sep 23, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just sending what I have.

We're going to want to make a clone of XdsCredentialsRegistry for CallCreds, because they are two different config namespaces, the gRFC says we'd create a new registry, and there's really no reason to provide both call creds and channel creds. However, I see that XdsCredentialsRegistry.getHardCodedClasses() should be deleted; we should just hard-code an empty list to InternalServiceProviders.loadAll(); none of this will be used on Android.

@ejona86 ejona86 self-requested a review September 23, 2025 23:42
@Zgoda91 Zgoda91 force-pushed the A97_jwt_token_call_creds branch from 9f97bb5 to 3a36865 Compare September 30, 2025 13:52
@Zgoda91
Copy link
Author

Zgoda91 commented Oct 1, 2025

@ejona86 - I applied the fixes from your latest comments.

I had to rebase the PR due to local compilation issues. However, all new changes can be found starting from commit 6: Default implementation for newCallCredentials

ejona86
ejona86 reviewed Oct 2, 2025
View reviewed changes
@Zgoda91
Copy link
Author

Zgoda91 commented Oct 3, 2025

@ejona86 - newest changes published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zgoda91 @ejona86