xds: Use unused variable to ignore the return value
#12388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
This sort of thing is public as well: https://errorprone.info/bugpattern/CheckReturnValue
|
So this workaround is fine, but how wrong is to check non-null against a constructor-returned object? I know that's not right programatically but since its a workaround... |
I would easily delete that code if I was updating things in the test. The purpose is not clear, as it is testing something impossible. |
shivaspeaks
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
shivaspeaks
changed the title
unused variable to ignore the return value
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Oct 6, 2025
Internal: cl/813142534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal: cl/813142534