Skip to content

Conversation

AgraVator
Copy link
Contributor

No description provided.

@AgraVator AgraVator requested a review from ejona86 September 30, 2025 16:48
@ejona86
Copy link
Member

ejona86 commented Sep 30, 2025

The issue was that it didn't propagate to metrics... but you don't test metrics. I'd expect changes to

private static final class ClientTracer extends ClientStreamTracer {

This can be considered a good step, as it is now propagated to the application. Basically, when you say "propagation" you need to say what you are propagating to. But this would only be one part of what had been discussed earlier. (And this can go in before the rest of the metrics is working.)

@ejona86 ejona86 added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Sep 30, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants