Skip to content

Allow EC Keys #12399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Allow EC Keys #12399

wants to merge 8 commits into from

Conversation

gtcooke94
Copy link
Contributor

SPIFFE Bundle Map parsing was originally implemented to only support RSA keys. It should also support EC keys.

matthewstevenson88
matthewstevenson88 reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a unit test that confirms that EC keys are accepted by the parser?

matthewstevenson88
matthewstevenson88 approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with 1 nit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewstevenson88 matthewstevenson88 matthewstevenson88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtcooke94 @matthewstevenson88