all: Update netty to 4.1.77.Final and netty_tcnative to 2.0.53.Final #9027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
force-pushed
the
upgrade-netty
branch
3 times, most recently
from
263f128 to
4ffb3cb
Compare
temawi
changed the title
temawi
force-pushed
the
upgrade-netty
branch
3 times, most recently
from
711238b to
ce8b750
Compare
temawi
changed the title
temawi
force-pushed
the
upgrade-netty
branch
2 times, most recently
from
e325ab0 to
ba76107
Compare
ejona86
approved these changes
Jun 24, 2022
examples/example-tls/pom.xml
Outdated
| @@ -57,6 +57,12 @@ | |||
| <version>${netty.tcnative.version}</version> | |||
| <scope>runtime</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.netty</groupId> | |||
| <artifactId>netty-tcnative-classes</artifactId> | |||
There was a problem hiding this comment.
I'd expect this not to be necessary for Maven. Remove this dependency?
Although, actually, I see you didn't update the build.gradle for this example. It is using grpc-netty-shaded. We should swap to using grpc-netty-shaded here and then we don't need to define netty-tcnative at all. I've tested that works without issue.
ejona86
approved these changes
Jun 24, 2022
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Jun 28, 2022
…rpc#9027) all: Update netty to 4.1.77.Final and netty_tcnative to 2.0.53.Final Also switches to a non-release version of rules_jvm_external to allow Bazel build to work with artifact classifiers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more complicated Netty upgrade as netty-tcnative was split into:
netty-tcnative-classesthat has all the Java codenetty-tcnative-boringssl-staticthat no longer has all of the native libraries, but instead declares dependencies to itself with a platform specific Maven classifiers (e.g.linux-x86_64)This causes problems for:
This PR includes direct dependencies to
netty-tcnative-boringssl-staticwith all the platform classifiers.The latest Bazel release also has a problem with using platform classifiers. This PR changes to use a non-released version of rules_jvm_external that has a fix to the problem (bazel-contrib/rules_jvm_external#687).