Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: fix RouteConfiguration not supporting contains and stringMatcher #9845

Merged

Conversation

olderwei
Copy link
Contributor

HeaderMatcher needs to support stringMatcher and contains, and the analysis of HeaderMatcher has already been implemented in MatcherParser. Therefore, I did the replacement.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: olderwei / name: chenwei321 (dbbee3d)

@olderwei olderwei force-pushed the header-matcher-support-string-matcher branch 3 times, most recently from d562da4 to 4c25575 Compare January 18, 2023 12:12
@olderwei olderwei force-pushed the header-matcher-support-string-matcher branch from 4c25575 to dbbee3d Compare January 18, 2023 12:20
@ejona86 ejona86 requested a review from YifeiZhuang January 19, 2023 00:31
Copy link
Contributor

@YifeiZhuang YifeiZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up.

@YifeiZhuang YifeiZhuang merged commit b289519 into grpc:master Jan 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants