Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #154, correcting capitalization of proto files which don't follow the style guide. #189

Merged
merged 5 commits into from
Oct 12, 2020
Merged

Fix #154, correcting capitalization of proto files which don't follow the style guide. #189

merged 5 commits into from
Oct 12, 2020

Conversation

lowasser
Copy link
Collaborator

@lowasser lowasser commented Oct 7, 2020 •
edited by bshaffer
Loading

Fixes #154

@lowasser lowasser self-assigned this Oct 7, 2020
@lowasser lowasser requested a review from bshaffer October 10, 2020 00:02
bshaffer
bshaffer approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bshaffer bshaffer merged commit bc0882f into grpc:master Oct 12, 2020
@bshaffer bshaffer mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees

@lowasser lowasser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Proto outer classname in generated code, does not compile
2 participants
@lowasser @bshaffer