add test case for partially set options

grpc · Apr 5, 2024 · 1e37caa · 1e37caa
1 parent 27d6087
commit 1e37caa
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/packages/proto-loader/test/descriptor_type_test.ts b/packages/proto-loader/test/descriptor_type_test.ts
@@ -139,7 +139,7 @@ describe('Descriptor types', () => {
  const service = packageDefinition.Hello as proto_loader.ServiceDefinition
  assert.deepStrictEqual(service.Hello.options, {
  deprecated: true,
- idempotency_level: 'IDEMPOTENCY_UNKNOWN',
+ idempotency_level: 'NO_SIDE_EFFECTS',
  uninterpreted_option: {
  name: {
  name_part: 'foo',
@@ -165,5 +165,17 @@ describe('Descriptor types', () => {
  idempotency_level: 'IDEMPOTENCY_UNKNOWN',
  uninterpreted_option: []
  })
+ assert.deepStrictEqual(service.HelloWithSomeOptions.options, {
+ deprecated: true,
+ idempotency_level: 'IDEMPOTENCY_UNKNOWN',
+ uninterpreted_option: [],
+ '(google.api.http)': {
+ get: "/hello",
+ additional_bindings: {
+ body: '*',
+ get: '/hello-world'
+ }
+ },
+ })
  })
 });
diff --git a/packages/proto-loader/test_protos/method_options.proto b/packages/proto-loader/test_protos/method_options.proto
@@ -13,7 +13,7 @@ message MethodSignature {
 service Hello {
  rpc Hello (Empty) returns (Empty) {
  option deprecated = true;
- option idempotency_level = IDEMPOTENCY_UNKNOWN;
+ option idempotency_level = NO_SIDE_EFFECTS;
  option uninterpreted_option = {
  name: {
  name_part: 'foo'
@@ -35,4 +35,14 @@ service Hello {
  option (google.api.method_signature) = 'bar';
  }
  rpc HelloWithoutOptions (Empty) returns (Empty) {}
+ rpc HelloWithSomeOptions (Empty) returns (Empty) {
+ option deprecated = true;
+ option (google.api.http) = {
+ get: "/hello"
+ additional_bindings: {
+ get: "/hello-world"
+ body: "*"
+ }
+ };
+ }
 }