Fix handling of subject alternative names with colons

grpc · Feb 21, 2025 · 7d99c4a · 7d99c4a
1 parent 65f4d76
commit 7d99c4a
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/packages/grpc-js-xds/src/load-balancer-cds.ts b/packages/grpc-js-xds/src/load-balancer-cds.ts
@@ -84,11 +84,13 @@ class DnsExactValueMatcher implements ValueMatcher {
     }
   }
   apply(entry: string): boolean {
-    let [type, value] = entry.split(':');
-    if (!isSupportedSanType(type)) {
+    const colonIndex = entry.indexOf(':');
+    if (colonIndex < 0) {
       return false;
     }
-    if (!value) {
+    const type = entry.substring(0, colonIndex);
+    let value = entry.substring(colonIndex + 1);
+    if (!isSupportedSanType(type)) {
       return false;
     }
     if (this.ignoreCase) {
@@ -137,14 +139,16 @@ class SanEntryMatcher implements ValueMatcher {
     }
   }
   apply(entry: string): boolean {
-    let [type, value] = entry.split(':');
-    if (!isSupportedSanType(type)) {
+    const colonIndex = entry.indexOf(':');
+    if (colonIndex < 0) {
       return false;
     }
-    value = canonicalizeSanEntryValue(type, value);
-    if (!entry) {
+    const type = entry.substring(0, colonIndex);
+    let value = entry.substring(colonIndex + 1);
+    if (!isSupportedSanType(type)) {
       return false;
     }
+    value = canonicalizeSanEntryValue(type, value);
     return this.childMatcher.apply(value);
   }
   toString(): string {