Fix a bug that caused HTTP2 sessions to be considered connected early

grpc · Feb 19, 2025 · bdd0dc8 · bdd0dc8
1 parent 5f12dc2
commit bdd0dc8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/packages/grpc-js/src/transport.ts b/packages/grpc-js/src/transport.ts
@@ -685,7 +685,7 @@ export class Http2SubchannelConnector implements SubchannelConnector {
       let errorMessage = 'Failed to connect';
       let reportedError = false;
       session.unref();
-      session.once('connect', () => {
+      session.once('remoteSettings', () => {
         session.removeAllListeners();
         resolve(new Http2Transport(session, address, options, remoteName));
         this.session = null;

diff --git a/packages/grpc-js/test/test-channel-credentials.ts b/packages/grpc-js/test/test-channel-credentials.ts
@@ -201,6 +201,21 @@ describe('ChannelCredentials usage', () => {
         done();
       }
     );
-
-  })
+  });
+  it('Should never connect when using insecure creds with a secure server', done => {
+    const client = new echoService(`localhost:${portNum}`, grpc.credentials.createInsecure());
+    const deadline = new Date();
+    deadline.setSeconds(deadline.getSeconds() + 1);
+    client.echo(
+      { value: 'test value', value2: 3 },
+      new grpc.Metadata({waitForReady: true}),
+      {deadline},
+      (error: ServiceError, response: any) => {
+        client.close();
+        assert(error);
+        assert.strictEqual(error.code, grpc.status.DEADLINE_EXCEEDED);
+        done();
+      }
+    );
+  });
 });