Add error code name to status error messages #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
reviewed
Dec 15, 2017
| let message = `${status.code} ${status.name}: ${status.details}`; | ||
| let error = new Error(message); | ||
| error.code = status.code; | ||
| error.details = status.details; |
There was a problem hiding this comment.
Should we include error.metadata as well?
There was a problem hiding this comment.
Yes. That is actually what I meant to write there. The details string is in the message. It probably doesn't need to be in a separate field too.
kjin
approved these changes
Dec 15, 2017
|
LGTM once tests are amended to reflect new message changes |
|
I was lazy and didn't run the tests, so I didn't realized that I had so many tests that depended on the specific text of the error messages. I'll have to think about how to handle that. |
|
My solution is to add a details string to the error objects that exactly matches the original details string, and check that in the tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We frequently get questions that reference status errors, but they almost never realize that the
codeis important or know what it means. This adds the status code number and name to the error message.