Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto-generated service definition #1778

Merged
merged 2 commits into from
May 6, 2021
Merged

Fix auto-generated service definition #1778

merged 2 commits into from
May 6, 2021

Conversation

EduardoLaranjo
Copy link
Contributor

relate to issue #1766

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 4, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@murgatroid99
Copy link
Member

This looks like a good change, but I can't accept it until you sign the CLA. Also, please run npm run compile and npm run generate-golden to regenerate the golden test files, and add the results to this PR.

@EduardoLaranjo
Copy link
Contributor Author

hi @murgatroid99 I will do that

@EduardoLaranjo
Copy link
Contributor Author

hi @murgatroid99 where are the proto files located

@murgatroid99
Copy link
Member

I think you have to update git submodules to get them (git submodule update --init --recursive).

@EduardoLaranjo
Copy link
Contributor Author

EduardoLaranjo commented May 5, 2021 •
edited
Loading

Yup that worked, appreciated 👍.

I have generate the new golden files, they look fine.

murgatroid99
murgatroid99 approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@murgatroid99 murgatroid99 merged commit 4ed3bcf into grpc:master May 6, 2021
@murgatroid99 murgatroid99 mentioned this pull request May 6, 2021
Merged
@EduardoLaranjo EduardoLaranjo deleted the patch-1 branch May 7, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EduardoLaranjo @murgatroid99 @kokoro-team