grpc-js: pick_first: fix currentPick comparison in resetSubchannelList #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
force-pushed
the
grpc-js_pick_first_reset_listener_fix
branch
from
efdcc28 to
6d4e08c
Compare
gnossen
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the cause of #2621. This is a very similar problem to the one fixed in #2559. The potential incorrect behavior here is that a subchannel in the subchannel list is the same as the one that has been picked, but it is wrapped with a different object so the check here compares false, resulting in removing the listener erroneously. That would cause pick_first to not react to subsequent changes in the subchannel state, which matches the log shown in #2621. I don't actually know of a code path that could cause this this outcome, but it's best to be consistent in how we check this anyway.