-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-js-xds: Implement EDS dualstack support #2665
Merged
murgatroid99
merged 2 commits into
grpc:master
from
murgatroid99:grpc-js-xds_eds_dualstack
Feb 15, 2024
Merged
grpc-js-xds: Implement EDS dualstack support #2665
murgatroid99
merged 2 commits into
grpc:master
from
murgatroid99:grpc-js-xds_eds_dualstack
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Feb 15, 2024
gnossen
approved these changes
Feb 15, 2024
This was referenced Aug 16, 2024
This was referenced Sep 1, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the EDS part of gRFC A61. Node does not have stateful session affinity, so that part does not apply.
The first commit is just updating the Envoy API dependency to the same commit hash that grpc/grpc references, and updating the generated code, in order to pick up the change that added the
additional_addresses
field to theEndpoint
message. The second commit has the actual substance of the change.