-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-js-xds: Implement xDS Server #2783
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Jul 2, 2024
This was referenced Aug 16, 2024
This was referenced Sep 1, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement A36: xDS-Enabled Servers
. This adds the class
XdsServer
to the grpc-js-xds library. TheXdsServer
class inherits from theServer
class in grpc-js, so it has the same API except thatbindAsync
's first argument only acceptsIP address:port
strings. It also adds the methodsaddServingStateListener
andremoveServingStateListener
to listen for serving state changes for a particular bound port.This PR also includes a couple of grpc-js changes that were prerequisites for
XdsServer
functionality:ServerInterceptingCall#getHost
in order to do virtual host selection in the route interceptor.experimental.createServerCredentialsWithInterceptors
as a way to associate interceptors with specific listening ports.