Remove broken build badge from README #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
|
I think that badge would also be potentially misleading. It only describes the grpc-tools package build, and doesn't represent anything about the primary library in this repository (grpc-js). |
|
It doesn't look like there is a GH action for Otherwise, may as well just remove the badge altogether I suppose. |
|
The grpc-js tests are run elsewhere, and there isn't a badge for it. I think removing the badge entirely is the best option. |
MasterOdin
changed the title
|
Done |
murgatroid99
approved these changes
Nov 7, 2024
|
Thank you for taking the time to improve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replaces the build badge in the README from one used from Travis (which the repo doesn't use) with one provided by GH actions.