Fix server keep alive timeout not properly destroying connections #3022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
GitHub Issue: #2953
Reporter: @zabranskiy
Package: @grpc/grpc-js
Severity: Bug - Server connections hang indefinitely when clients don't respond to keepalive pings
Root Cause
The server-side keepalive ping timeout handler uses
session.close()to terminate connections when clients fail to respond to keepalive pings. However,session.close()performs a graceful shutdown that does not forcibly terminate the underlying connection, causing it to hang indefinitely.Fix Summary
Changed keepalive error handlers to use
session.destroy()instead ofsession.close()to forcibly close connections when:Files Modified
packages/grpc-js/src/server.ts(6 occurrences changed)_sessionHandlermethod (lines ~1609, ~1635, ~1643)_channelzSessionHandlermethod (lines ~1807, ~1830, ~1843)Testing Recommendations
To verify the fix:
Consistency
This change aligns server-side keepalive handling with the client-side transport implementation (
packages/grpc-js/src/transport.ts), which already usessession.destroy()viahandleDisconnect()for keepalive timeouts.Backward Compatibility
This is a bug fix that should not affect normal operation: