Skip to content

grpc-js: Re-add a couple of accidentally removed HTTP/2 session settings #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murgatroid99 merged 1 commit into from
Nov 7, 2025
Merged

grpc-js: Re-add a couple of accidentally removed HTTP/2 session settings #3023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grpc-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@grpc/grpc-js",
"version": "1.14.0",
"version": "1.14.1",
"description": "gRPC Library for Node - pure JS implementation",
"homepage": "https://grpc.io/",
"repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",
Expand Down
8 changes: 7 additions & 1 deletion packages/grpc-js/src/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,13 @@ export class Http2SubchannelConnector implements SubchannelConnector {
initialWindowSize:
options['grpc-node.flow_control_window'] ??
http2.getDefaultSettings?.()?.initialWindowSize ?? 65535,
}
},
maxSendHeaderBlockLength: Number.MAX_SAFE_INTEGER,
/* By default, set a very large max session memory limit, to effectively
* disable enforcement of the limit. Some testing indicates that Node's
* behavior degrades badly when this limit is reached, so we solve that
* by disabling the check entirely. */
maxSessionMemory: options['grpc-node.max_session_memory'] ?? Number.MAX_SAFE_INTEGER
};
const session = http2.connect(`${scheme}://${targetPath}`, sessionOptions);
// Prepare window size configuration for remoteSettings handler
Expand Down