Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename interceptors module #31

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Rename interceptors module #31

merged 2 commits into from
Jan 24, 2025

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Jan 24, 2025

This PR renames the GRPCInterceptors module to GRPCOTelTracingInterceptor.

@gjcairo gjcairo requested a review from glbrntt January 24, 2025 11:02
@gjcairo gjcairo added the ⚠️ semver/major Breaks existing public API. label Jan 24, 2025
@gjcairo
Copy link
Collaborator Author

gjcairo commented Jan 24, 2025

Is a module name change a breaking change? Not sure.

@gjcairo gjcairo force-pushed the rename-interceptors branch from facc0c8 to 027920e Compare January 24, 2025 11:04
glbrntt
glbrntt requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, I think the target should be plural as we have client and server interceptors

@glbrntt
Copy link
Collaborator

glbrntt commented Jan 24, 2025

Is a module name change a breaking change? Not sure.

Yup, if you depended on the module before your build will break because the module no longer exists!

@glbrntt
Copy link
Collaborator

glbrntt commented Jan 24, 2025

I think you'll need to update .spi.yml as well for the docs check to pass

@gjcairo gjcairo requested a review from glbrntt January 24, 2025 11:42
@gjcairo gjcairo force-pushed the rename-interceptors branch from 2f4a213 to f941b31 Compare January 24, 2025 11:42
@glbrntt glbrntt merged commit 33b362b into grpc:main Jan 24, 2025
21 checks passed
@gjcairo gjcairo deleted the rename-interceptors branch January 24, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjcairo @glbrntt