Skip to content

Commit

Permalink
Avoid using accidental public API (#47)
Browse files Browse the repository at this point in the history
Motivation:

NIOs underscored Base64 module accidentally leaked some public API as
extensions on `String`. We shouldn't use these.

Modifications:

- Vend base64 encoding
- Use it instead of NIOs API

Result:

Avoid using accidentally public API
  • Loading branch information
glbrntt authored Dec 12, 2024
1 parent 7b9b6f3 commit f251497
Show file tree
Hide file tree
Showing 3 changed files with 758 additions and 1 deletion.
25 changes: 25 additions & 0 deletions NOTICES.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
The gRPC Swift Project
======================

Copyright 2024 The gRPC Swift Project

The gRPC Swift project licenses this file to you under the Apache License,
version 2.0 (the "License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at:

https://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
License for the specific language governing permissions and limitations
under the License.

-------------------------------------------------------------------------------

This product uses derivations of swift-extras/swift-extras-base64 'Base64.swift'.

* LICENSE (Apache License 2.0):
* https://github.com/swift-extras/swift-extras-base64/blob/main/LICENSE
* HOMEPAGE:
* https://github.com/swift-extras/swift-extras-base64
2 changes: 1 addition & 1 deletion Sources/GRPCNIOTransportCore/GRPCStreamStateMachine.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1866,7 +1866,7 @@ extension Metadata {
for header in headers {
if header.name.hasSuffix("-bin") {
do {
let decodedBinary = try header.value.base64Decoded()
let decodedBinary = try Base64.decode(string: header.value)
metadata.addBinary(decodedBinary, forKey: header.name)
} catch {
metadata.addString(header.value, forKey: header.name)
Expand Down
Loading

0 comments on commit f251497

Please sign in to comment.