Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround #43 in tests #44

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Workaround #43 in tests #44

merged 1 commit into from
Dec 6, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 6, 2024

Motivation:

A couple of tests fail sometimes, the root cause of which is #43.

Modifications:

  • Wait for all messages to be received before closing

Result:

Tests are more stable

Motivation:

A couple of tests fail sometimes, the root cause of which is grpc#43.

Modifications:

- Wait for all messages to be received before closing

Result:

Tests are more stable
@glbrntt glbrntt added the semver/none No version bump required. label Dec 6, 2024
@glbrntt glbrntt requested a review from gjcairo December 6, 2024 13:24
@glbrntt glbrntt enabled auto-merge (squash) December 6, 2024 13:24
@glbrntt glbrntt merged commit 6c0bc45 into grpc:main Dec 6, 2024
26 of 29 checks passed
@glbrntt glbrntt deleted the deflake branch December 6, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants