Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MemberImportVisibility check on all targets #45

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

rnro
Copy link
Collaborator

@rnro rnro commented Dec 9, 2024

Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.

@rnro rnro added the semver/none No version bump required. label Dec 9, 2024
@rnro rnro force-pushed the enable_MemberImportVisibility_check branch from 7f198d0 to 9d8e30a Compare December 10, 2024 10:35
@rnro rnro changed the title Enable MemberImportVisibility check on 6.0+ pipelines Enable MemberImportVisibility check on all targets Dec 10, 2024
@rnro rnro force-pushed the enable_MemberImportVisibility_check branch from 9d8e30a to f3f22f8 Compare December 10, 2024 10:43
@rnro rnro force-pushed the enable_MemberImportVisibility_check branch from f3f22f8 to e08e33d Compare December 11, 2024 09:18
@rnro rnro enabled auto-merge (squash) December 11, 2024 14:50
@glbrntt
Copy link
Collaborator

glbrntt commented Dec 11, 2024

@rnro nightly fails because of an import visibility check which should be fixed by #47

I'll approve + merge etc., once the above has been merged (and any other fallout from setting the member import visibility)

@rnro rnro merged commit a7b2f50 into grpc:main Dec 12, 2024
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants