Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Protobuf breaking changes #288

Closed
anjmao opened this issue Aug 15, 2018 · 0 comments · Fixed by #289
Closed

Swift Protobuf breaking changes #288

anjmao opened this issue Aug 15, 2018 · 0 comments · Fixed by #289

Comments

@anjmao
Copy link
Contributor

anjmao commented Aug 15, 2018

Hi,

I'm using Docker to build swift grpc protoc plugins. Recently apple released new swift-protobuf 1.1.1 version which is breaking grpc-swift.

This is my docker file

FROM swift:latest as swift_builder
RUN git clone https://github.com/grpc/grpc-swift \
    && cd grpc-swift \
    && make \
    && cp protoc-gen-swift protoc-gen-swiftgrpc /usr/bin/ \
    && cd / \
    && rm -rf grpc-swift

From logs I see that it resolves

Cloning https://github.com/apple/swift-protobuf.git
Resolving https://github.com/apple/swift-protobuf.git at 1.1.1
Compile Swift Module 'SwiftProtobuf' (76 sources)
Compile Swift Module 'Commander' (9 sources)
Compile Swift Module 'RootsEncoder' (1 sources)
Linking ./.build/x86_64-unknown-linux/debug/RootsEncoder
Compile Swift Module 'SwiftProtobufPluginLibrary' (18 sources)
Compile Swift Module 'SwiftGRPC' (32 sources)
Compile Swift Module 'Simple' (1 sources)
Compile Swift Module 'Echo' (4 sources)
Linking ./.build/x86_64-unknown-linux/debug/Simple
Linking ./.build/x86_64-unknown-linux/debug/Echo
Compile Swift Module 'protoc_gen_swift' (18 sources)
Linking ./.build/x86_64-unknown-linux/debug/protoc-gen-swift
Compile Swift Module 'protoc_gen_swiftgrpc' (9 sources)
Linking ./.build/x86_64-unknown-linux/debug/protoc-gen-swiftgrpc
Fetching https://github.com/apple/swift-protobuf.git
Fetching https://github.com/kylef/Commander.git
Fetching https://github.com/apple/swift-nio-zlib-support.git
Fetching https://github.com/apple/swift-nio-ssl-support.git
Fetching https://github.com/kylef/Spectre.git
Cloning https://github.com/apple/swift-protobuf.git
Resolving https://github.com/apple/swift-protobuf.git at 1.1.1

It looks like the problem is here https://github.com/grpc/grpc-swift/blob/master/Package.swift#L21. I could make a PR to lock versions.

rebello95 added a commit to rebello95/grpc-swift that referenced this issue Aug 18, 2018
We should issue a new release which includes grpc#289 (the fix for grpc#288).
IceRocky pushed a commit to IceRocky/grpc-swift that referenced this issue May 28, 2024
We should issue a new release which includes grpc/grpc-swift#289 (the fix for grpc/grpc-swift#288).
teskobif7 added a commit to teskobif7/grpc-swift that referenced this issue Aug 14, 2024
We should issue a new release which includes grpc/grpc-swift#289 (the fix for grpc/grpc-swift#288).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant