-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Swift reserved names when generating function names #1213
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good although I've left a couple of nits.
Co-authored-by: George Barnett <gbarnett@apple.com>
Thanks @glbrntt |
@ialimz could you run |
The other failures here are #1215 -- we can ignore those for now. |
@glbrntt SwiftFormat changes have been applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ialimz!
This PR fixes a bug that causes the Generator not to consider Swift reserved names such as the
do
keyword.For example, assume we have an RPC like below:
If we don't consider Swift's
do
keyword, we will be going to have a compile error.With these changes, the generated code should be like below: