-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend lifetime of client interceptor pipeline #1265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A client call (i.e. the object the user holds) may live longer than the transport associated with it (roughly speaking, the http/2 stream channel). An example of this is when interceptors are use to retry and RPC and redirect responses back to the original call. However, the interceptor pipeline is held by the transport and is currently set to nil when the transport is removed from the channel. This means events invoked from the call object (such as cancellation) which go via the transport (holding the interceptor pipeline) are incorrectly failed. Modifications: - Have the client interceptor pipeline break the ref cycle between the transport and itself when the interceptor pipeline closes rather than when the transport is closed - Emit a cancellation status rater than error on cancellation - Update the ordering of when close is called in the interceptor pipeline. - Add and update tests Result: "sub"-RPCs may be cancelled.
Davidde94
reviewed
Sep 15, 2021
Lukasa
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice change.
fabianfett
reviewed
Sep 15, 2021
fabianfett
reviewed
Sep 16, 2021
fabianfett
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A client call (i.e. the object the user holds) may live longer than the
transport associated with it (roughly speaking, the http/2 stream channel). An
example of this is when interceptors are use to retry and RPC and
redirect responses back to the original call.
However, the interceptor pipeline is held by the transport and is
currently set to nil when the transport is removed from the channel.
This means events invoked from the call object (such as cancellation)
which go via the transport (holding the interceptor pipeline) are
incorrectly failed.
Modifications:
transport and itself when the interceptor pipeline closes rather than
when the transport is closed
pipeline.
Result:
"sub"-RPCs may be cancelled.