Wire up connection backoff of channel pool #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `GRPCChannelPool.Configuration` has an entry controlling connection backoff configuration. However this was never wired up to the underlying connection pool and connections which just use the defaults. Modifications: - Propagate connection backoff through the API - Add a test Result: Connection backoff is wired up as expected for `GRPCChannelPool`.
Lukasa
approved these changes
Oct 5, 2021
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Nov 10, 2021
Motivation: `GRPCChannelPool.Configuration` has an entry controlling connection backoff configuration. However this was never wired up to the underlying connection pool and connections which just use the defaults. Modifications: - Propagate connection backoff through the API - Add a test Result: Connection backoff is wired up as expected for `GRPCChannelPool`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
GRPCChannelPool.Configurationhas an entry controlling connectionbackoff configuration. However this was never wired up to the underlying
connection pool and connections which just use the defaults.
Modifications:
Result:
Connection backoff is wired up as expected for
GRPCChannelPool.