Add co-operative cancellation to async writer and passthrough source #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Whenever we create continuations we should be careful to add support for co-operative cancellation via a cancellation handler. Modifications: - Add co-operative cancellation to the async write and passthrough source - Tests Result: Better cancellation support
fabianfett
reviewed
May 27, 2022
| } | ||
| } | ||
| } onCancel: { | ||
| self.cancelAsynchronously() |
There was a problem hiding this comment.
I think, this should just be cancel. No need to create another task.
Suggested change
| self.cancelAsynchronously() | |
| self.cancel() |
There was a problem hiding this comment.
This doesn't work unfortunately: Actor-isolated instance method 'cancel()' can not be referenced from a Sendable closure
IIUC onCancel is not executed on the actor but a different thread (which makes sense as it runs immediately when cancelled), so I think this makes sense.
| throw GRPCAsyncWriterError.tooManyPendingWrites | ||
| } | ||
| } onCancel: { | ||
| self.cancelAsynchronously() |
There was a problem hiding this comment.
No need for redispatch into the AsyncWriter
Suggested change
| self.cancelAsynchronously() | |
| self.cancel() |
fabianfett
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Whenever we create continuations we should be careful to add support for
co-operative cancellation via a cancellation handler.
Modifications:
source
Result:
Better cancellation support