Build release plugins as universal binaries #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We upload protoc plugins for each release. As it stands, the architecture these plugins are built for is that of the machine building them. We should upload universal binaries instead. Modifications: - Modify the bundling script to build universal binaries Result: Better platform support for the uploaded macOS plugins.
glbrntt
force-pushed
the
gb-universal-plugins
branch
from
3f30b1c to
d07041e
Compare
Lukasa
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We upload protoc plugins for each release. As it stands, the
architecture these plugins are built for is that of the machine building
them. We should upload universal binaries instead.
Modifications:
Result:
Better platform support for the uploaded macOS plugins.