Add async implementation of QPSBenchmark #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We want to provide an async/await version of the QPSBenchmark implementation, and be able to choose whether we want to use that or the ELF version when running the performance tests via the gRPC JSON driver. Modifications: - Added full async/await-based implementations of the worker, server, and client. - Created a new command line flag (`--use-async`) to choose between the EventLoopFuture and async/await versions when running the tests. Result: QPSBenchmark can optionally be executed using an async/await implementation.
glbrntt
reviewed
Aug 11, 2022
Performance/QPSBenchmark/Sources/QPSBenchmark/Runtime/Async/AsyncPingPongRequestMaker.swift
Show resolved
Hide resolved
Performance/QPSBenchmark/Sources/QPSBenchmark/Runtime/Async/AsyncQPSClientImpl.swift
Outdated
Show resolved
Hide resolved
Performance/QPSBenchmark/Sources/QPSBenchmark/Runtime/Async/AsyncQPSClientImpl.swift
Show resolved
Hide resolved
Performance/QPSBenchmark/Sources/QPSBenchmark/Runtime/Async/AsyncQPSClientImpl.swift
Outdated
Show resolved
Hide resolved
glbrntt
approved these changes
Aug 11, 2022
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: We want to provide an async/await version of the QPSBenchmark implementation, and be able to choose whether we want to use that or the ELF version when running the performance tests via the gRPC JSON driver. Modifications: - Added full async/await-based implementations of the worker, server, and client. - Created a new command line flag (`--use-async`) to choose between the EventLoopFuture and async/await versions when running the tests. Result: QPSBenchmark can optionally be executed using an async/await implementation.
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: We want to provide an async/await version of the QPSBenchmark implementation, and be able to choose whether we want to use that or the ELF version when running the performance tests via the gRPC JSON driver. Modifications: - Added full async/await-based implementations of the worker, server, and client. - Created a new command line flag (`--use-async`) to choose between the EventLoopFuture and async/await versions when running the tests. Result: QPSBenchmark can optionally be executed using an async/await implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to provide an async/await version of the QPSBenchmark implementation, and be able to choose whether we want to use that or the ELF version when running the performance tests via the gRPC JSON driver.
Modifications:
--use-async) to choose between the EventLoopFuture and async/await versions when running the tests.Result:
QPSBenchmark can optionally be executed using an async/await implementation.