Add SPM plugin for GRPC code generation #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t089
reviewed
Aug 30, 2022
|
@gjcairo can you split this into two PRs? One to add an SPM plugin and another to adopt it in the QPS benchmark? |
## Motivation After adding an SPM plugin for protobuf generation, we want to offer the same feature for GRPC code generation. ## Modifications * Added a GRPC codegen SPM plugin ## Result GRPC codegen SPM plugin is now available.
glbrntt
requested changes
Aug 30, 2022
FranzBusch
reviewed
Aug 30, 2022
gjcairo
requested review from
FranzBusch and
glbrntt
and removed request for
FranzBusch
glbrntt
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
One nit, looks good otherwise. I'll let @FranzBusch also review as he has more expertise here.
glbrntt
approved these changes
Aug 31, 2022
FranzBusch
reviewed
Aug 31, 2022
hudsontrius80A
approved these changes
Sep 15, 2022
hudsontrius80A
approved these changes
Sep 15, 2022
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
* Add SPM plugin for GRPC code generation ## Motivation After adding an SPM plugin for protobuf generation, we want to offer the same feature for GRPC code generation. ## Modifications * Added a GRPC codegen SPM plugin ## Result GRPC codegen SPM plugin is now available. * PR changes * Folder rename * Fixes typo in docs * Changes in docs
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
* Add SPM plugin for GRPC code generation ## Motivation After adding an SPM plugin for protobuf generation, we want to offer the same feature for GRPC code generation. ## Modifications * Added a GRPC codegen SPM plugin ## Result GRPC codegen SPM plugin is now available. * PR changes * Folder rename * Fixes typo in docs * Changes in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After adding an SPM plugin for protobuf generation, we want to offer the same feature for GRPC code generation.
Modifications
Result
GRPC codegen SPM plugin is now available.