Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forward looking SwiftProtobuf API #1482

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Sep 8, 2022

Motivation:

SwiftProtobuf would like to remove some of the plugin library
code in its next major release. We would like to allow gRPC to
rely on SwiftProtobuf in both major versions.

We use a few of the APIs marked for removal but can switch
away from them easily as replacement APIs have been backported
to the 1.x branch.

Modifications:

  • Raise the minimum protobuf version
  • Use the new APIs

Result:

  • We can depend on protobuf 1.x and 2.x when it becomes available.

@glbrntt glbrntt marked this pull request as ready for review September 23, 2022 17:28
@glbrntt glbrntt requested a review from FranzBusch September 23, 2022 17:28
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Sep 23, 2022
@glbrntt
Copy link
Collaborator Author

glbrntt commented Sep 23, 2022

fyi @thomasvl

Copy link
Collaborator

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glbrntt glbrntt merged commit 7fcc7bc into grpc:main Sep 26, 2022
@glbrntt glbrntt deleted the gb-protobuf-1.x branch September 26, 2022 15:19
WendellXY pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
pinlin168 pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants