Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid command line args from the example #1496

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Remove invalid command line args from the example #1496

merged 1 commit into from
Oct 4, 2022

Conversation

lkstc112233
Copy link
Contributor

These two args has been removed since 1.8 and is on by default. Passing in these two args will result in the grpc stub not being generated at all.

@lkstc112233
Remove invalid command line args from the example
9e734e9 
These two args has been removed since 1.8 and is on by default. Passing in these two args will result in the grpc stub not being generated at all.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 1, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lkstc112233 / name: Photon cat (9e734e9)

Lukasa
Lukasa approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me! Can you please sign the CLA?

@lkstc112233
Copy link
Contributor Author

Hey Lukasa, thank you for your review! I have signed the SLA.

@Lukasa Lukasa added the semver/none No version bump required. label Oct 4, 2022
@Lukasa Lukasa merged commit 4a1fab1 into grpc:main Oct 4, 2022
@lkstc112233 lkstc112233 deleted the patch-1 branch October 4, 2022 08:29
WendellXY pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
@lkstc112233 @WendellXY
Remove invalid command line args from the example (grpc#1496)
cf9914c 
These two args has been removed since 1.8 and is on by default. Passing in these two args will result in the grpc stub not being generated at all.
pinlin168 pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
@lkstc112233 @pinlin168
Remove invalid command line args from the example (grpc#1496)
2270462 
These two args has been removed since 1.8 and is on by default. Passing in these two args will result in the grpc stub not being generated at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkstc112233 @Lukasa