Use iterator when checking encoding headers #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: SwiftNIO HTTP/2 1.24.0 added a method for retrieving a sequence of header values rather than directly returning an array of values. We can use it when checking the encoding header as there should only be at most one value. Modifications: - Update HTTP/2 to be min 1.24.0 - Use the iterator API Result: Fewer allocations.
Lukasa
approved these changes
Feb 7, 2023
glbrntt
force-pushed
the
gb-headers-sequence
branch
from
e1fcc05 to
9e422c1
Compare
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: SwiftNIO HTTP/2 1.24.0 added a method for retrieving a sequence of header values rather than directly returning an array of values. We can use it when checking the encoding header as there should only be at most one value. Modifications: - Update HTTP/2 to be min 1.24.0 - Use the iterator API Result: Fewer allocations.
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: SwiftNIO HTTP/2 1.24.0 added a method for retrieving a sequence of header values rather than directly returning an array of values. We can use it when checking the encoding header as there should only be at most one value. Modifications: - Update HTTP/2 to be min 1.24.0 - Use the iterator API Result: Fewer allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SwiftNIO HTTP/2 1.24.0 added a method for retrieving a sequence of header values rather than directly returning an array of values. We can use it when checking the encoding header as there should only be at most one value.
Modifications:
Result:
Fewer allocations.