Migrate CI to use swiftlang / SwiftNIO common GitHub Actions. #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
adopt_standardized_github_actions
branch
2 times, most recently
from
3f145d1 to
1dcf6af
Compare
glbrntt
requested changes
Nov 5, 2024
Examples/hello-world/Protos.proto
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2015 gRPC authors. | |||
There was a problem hiding this comment.
Not sure what's happened here, but this is meant to be a symlink from Examples/hello-world/Protos/HelloWorld.proto to dev/protos/upstream/grpc/examples/helloworld.proto. Could you fix it?
rnro
force-pushed
the
adopt_standardized_github_actions
branch
3 times, most recently
from
412a7bf to
c105ec9
Compare
rnro
force-pushed
the
adopt_standardized_github_actions
branch
3 times, most recently
from
a32ccaf to
6bfd485
Compare
glbrntt
requested changes
Nov 6, 2024
rnro
force-pushed
the
adopt_standardized_github_actions
branch
2 times, most recently
from
5ffed88 to
09f2243
Compare
Motivation: * Reduce duplication * Centralise boilerplate changes when new Swift versions are picked up. * Benefit from centralised work to add new linting / test infrastructure. Modifications: Changes of note: * Use soundness checks from swiftlang/github-workflows. * Define a gRPC-specific soundness check which retains bespoke license-checking code for .swift files as the gRPC header style is very different to most templates and checks that generated code is up-to-date. Result: More test, linting, formatting coverage. More common CI with other Swift on Server projects.
rnro
force-pushed
the
adopt_standardized_github_actions
branch
from
09f2243 to
4608314
Compare
glbrntt
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
Changes of note:
Result:
More test, linting, formatting coverage. More common CI with other Swift on Server projects.