Add remote peer info to the server context #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's often useful to know the identity of the remote peer when handling RPCs. Modifications: - Add a 'peer' to the server context - Implement this for the in-process transport Result: Server RPCs have some idea what the address of remote peer is
|
API breakages is expected. |
rnro
reviewed
Dec 3, 2024
| @@ -47,13 +47,13 @@ struct ClientRPCExecutorTestHarness { | |||
|
|
|||
| switch transport { | |||
| case .inProcess: | |||
| let server = InProcessTransport.Server() | |||
| let server = InProcessTransport.Server(peer: "in-process") | |||
There was a problem hiding this comment.
Is it worth adding a pid to the test transports? Even adding something like :1234 might come in useful in the future just so formatting expectations are upheld.
rnro
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's often useful to know the identity of the remote peer when handling RPCs.
Modifications:
package, these should never have beenpublicResult:
Server RPCs have some idea what the address of remote peer is