Enable MemberImportVisibility check on all targets #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Dec 9, 2024
.github/workflows/main.yml
Outdated
| linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" | ||
| linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" | ||
| linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" | ||
| linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable -Xswiftc -enable-upcoming-feature -Xswiftc MemberImportVisibility" |
There was a problem hiding this comment.
Any reason we can't just add this to our default settings in the manifest?
Line 48 in e390c85
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
f6d98dc to
fe42d6f
Compare
rnro
changed the title
glbrntt
requested changes
Dec 10, 2024
Package.swift
Outdated
Comment on lines
121
to
129
| for target in package.targets { | ||
| var settings = target.swiftSettings ?? [] | ||
| settings.append(.enableUpcomingFeature("MemberImportVisibility")) | ||
| target.swiftSettings = settings | ||
| } |
There was a problem hiding this comment.
Can we just add this directly to the defaultSwiftSettings above so that they're all in the same place.
There was a problem hiding this comment.
The intention here is that many of the core Swift on Server repositories have a block of their package manifest which a common structure which can be easily be modified with a script. This block would be used to insert settings which we wish to apply across all repositories.
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
fe42d6f to
8450297
Compare
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
8450297 to
0ecbb57
Compare
glbrntt
added
🔨 semver/patch
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
2 times, most recently
from
0b4cf0e to
c1c96ac
Compare
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
c1c96ac to
1012986
Compare
glbrntt
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.