Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Foundation imports #2146

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Remove unused Foundation imports #2146

merged 2 commits into from
Dec 17, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 17, 2024

Motivation:

A few files unnecesarily import Foundation

Modifications:

Remove unused imports

Result:

Fewer dependencies

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Dec 17, 2024
@glbrntt
Remove unused Foundation imports
96e3e58 
Motivation:

A few files unnecesarily import Foundation

Modifications:

Remove unused imports

Result:

Fewer dependencies
@glbrntt glbrntt force-pushed the v2/foundation-essentials branch from afdccdb to 96e3e58 Compare December 17, 2024 15:42
@glbrntt
Copy link
Collaborator Author

glbrntt commented Dec 17, 2024

This is expected; and okay:

5 breaking changes detected in GRPCCodeGen:
  💔 API breakage: extension Array has removed conformance to EncodableWithConfiguration
  💔 API breakage: extension Array has removed conformance to DecodableWithConfiguration
  💔 API breakage: extension Array has removed conformance to DataProtocol
  💔 API breakage: extension Array has removed conformance to MutableDataProtocol
  💔 API breakage: extension Array has removed conformance to ContiguousBytes

@glbrntt glbrntt added 🆕 semver/minor Adds new public API. and removed 🔨 semver/patch No public API change. labels Dec 17, 2024
@glbrntt glbrntt requested a review from gjcairo December 17, 2024 16:11
@glbrntt glbrntt marked this pull request as ready for review December 17, 2024 16:36
@glbrntt glbrntt merged commit ec8db6a into grpc:main Dec 17, 2024
32 of 33 checks passed
@glbrntt glbrntt deleted the v2/foundation-essentials branch December 17, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcairo gjcairo gjcairo approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @gjcairo