Fix Metadata's description for prettier printing #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Jan 29, 2025
Sources/GRPCCore/Metadata.swift
Outdated
| @@ -494,15 +494,15 @@ extension Metadata.Value: ExpressibleByArrayLiteral { | |||
|
|
|||
| extension Metadata: CustomStringConvertible { | |||
| public var description: String { | |||
| String(describing: self.map({ ($0.key, $0.value) })) | |||
| String(describing: self.map({ ($0.key.description, $0.value.description) })) | |||
There was a problem hiding this comment.
Can you add a test to verify the description is as we'd expect for a single Metadata.Value and for a Metadata?
glbrntt
added
🔨 semver/patch
glbrntt
requested changes
Jan 29, 2025
glbrntt
reviewed
Jan 30, 2025
glbrntt
reviewed
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
Metadata's description to include quotes around string values.From this:
to this: