Carthage: support from iOS 9.0 #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
changed the title
MrMage
approved these changes
Aug 13, 2018
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
To be honest, the spurious changes are "less bad" than feared :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described at the end of #282, the current master gets
IPHONEOS_DEPLOYMENT_TARGETset to 11.4 by default. I believe 9.0 is more reasonable (mainly because my project targets 9.0, so that's negociable).Unfortunatly, I messed up in #282 and got the change merged without having the versioned
xcodeprojupdated. This PR fixes this.Also, it shows what kind of maintenance comes from supporting Carthage: running
make project-carthagegenerates thexcodeprojagain. And unfortunately, it is not deterministic. So this PR only adds a bunch ofIPHONEOS_DEPLOYMENT_TARGET = 9.0;to thexcodeproj, but still the order of the objects in the project file changes -_-.I have been testing this PR by building with Carthage and integrating the resulting frameworks in a project that was otherwise failing because of the deployment target. I still get error #272, but that's not in the scope of this PR.