Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/add question template #310

Merged
merged 3 commits into from
Sep 12, 2018
Merged

Conversation

tikidunpon
Copy link
Contributor

Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Let me know when I can merge this.

- [ ] Updated grpc-swift to the latest version
- [ ] I read the [Contribution Guidelines](https://github.com/grpc/grpc-swift/blob/master/CONTRIBUTING.md)
- [ ] I read [README](https://github.com/grpc/grpc-swift/blob/master/README.md)
- [ ] I searched for [existing GitHub issues](https://github.com/grpc/grpc-swift/issues)(especially, there are many [resolved issues related to SSL](https://github.com/grpc/grpc-swift/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aclosed+ssl))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super-nit: insert a space: issues) (

---
name: ❓ Support Question
about: Not sure how something works or how to implement some functionality? Ask us here! (But please check the README or issues first 🙃)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super-nit: can this empty line be removed?

@tikidunpon
Copy link
Contributor Author

@MrMage I've fixed template from your review, pls merge it:)

@MrMage MrMage merged commit 0faf1d6 into grpc:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants